EES-5401 update datablock to use geoJson API call instead of boundaryLevel parameter #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettstuart
changed the title
bennettstuart
force-pushed
the
EES-5401
branch
3 times, most recently
from
589379f to
ffe8834
Compare
bennettstuart
force-pushed
the
EES-5401
branch
5 times, most recently
from
7a04a73 to
598524f
Compare
ntsim
requested changes
Sep 3, 2024
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
...lore-education-statistics-common/src/modules/table-tool/utils/mapLocationOptionsToFilters.ts
Outdated
Show resolved
Hide resolved
...lore-education-statistics-common/src/modules/table-tool/utils/mapLocationOptionsToFilters.ts
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/services/tableBuilderService.ts
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/services/tableBuilderService.ts
Outdated
Show resolved
Hide resolved
bennettstuart
force-pushed
the
EES-5401
branch
from
bfb6049 to
ccf8b3e
Compare
ntsim
reviewed
Sep 4, 2024
src/explore-education-statistics-common/src/modules/find-statistics/hooks/useTableQuery.ts
Outdated
Show resolved
Hide resolved
...plore-education-statistics-common/src/modules/find-statistics/queries/tableBuilderQueries.ts
Outdated
Show resolved
Hide resolved
...plore-education-statistics-common/src/modules/find-statistics/queries/tableBuilderQueries.ts
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/table-tool/utils/mapFullTableMeta.ts
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/find-statistics/hooks/useTableQuery.ts
Outdated
Show resolved
Hide resolved
ntsim
reviewed
Sep 4, 2024
...ore-education-statistics-admin/src/pages/release/datablocks/components/DataBlockPageTabs.tsx
Outdated
Show resolved
Hide resolved
bennettstuart
force-pushed
the
EES-5401
branch
3 times, most recently
from
7458994 to
e52b4d2
Compare
ntsim
reviewed
Sep 8, 2024
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
...s-admin/src/pages/release/datablocks/components/chart/__tests__/ChartBuilderPreview.test.tsx
Outdated
Show resolved
Hide resolved
...s-admin/src/pages/release/datablocks/components/chart/__tests__/ChartBuilderPreview.test.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
bennettstuart
force-pushed
the
EES-5401
branch
from
de470c0 to
da22f35
Compare
EES-5401 moved geoJson data fetching to MapChartRenderer component wrapper EES-5401 fixed errors, tsc and tests etc EES-5401 Updated tests
bennettstuart
force-pushed
the
EES-5401
branch
from
da22f35 to
358eb89
Compare
ntsim
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket: EES-5401
Wired dataBlocks to use the new geoJson endpoint
boundaryLevelparameter being added togetDataBlockTableDatawith a wholly separate call to the recently added geoJson endpoint.This is the first of two PR's with embedding geoJson API into the frontend, the next will regard EES-5402