EES 5430 - Cancel and Removal of draft API datasets #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Added UI test to remove draft API dataset & EES-5432 Added UI test to cancel removing draft API dataset
|
|
saicharan2789
changed the title
mmyoungman
requested changes
Aug 23, 2024
tests/robot-tests/tests/public_api/public_api_dataset_cancel_and_removal.robot
Outdated
Show resolved
Hide resolved
tests/robot-tests/tests/public_api/public_api_dataset_cancel_and_removal.robot
Show resolved
Hide resolved
tests/robot-tests/tests/public_api/public_api_dataset_cancel_and_removal.robot
Outdated
Show resolved
Hide resolved
tests/robot-tests/tests/public_api/public_api_dataset_cancel_and_removal.robot
Outdated
Show resolved
Hide resolved
mmyoungman
approved these changes
Aug 30, 2024
| user clicks button Create API data set | ||
| ${modal}= user waits until modal is visible Create a new API data set | ||
| user chooses select option id:apiDataSetCreateForm-releaseFileId ${SUBJECT_NAME_1} | ||
| user clicks button by index Cancel 3 |
There was a problem hiding this comment.
Just noting that I think selecting like this can make the test fragile, as if a new cancel button gets added to the page, this test will break.
But I don't think this is a big deal / worth the time to change, so no need to change this. I'm more just highlighting that we want to make the tests as robust against future changes where feasible. Generally in this situation I'd be inclined to add a way to select a parent element first and then select the cancel button within that parent element.
I can imagine there are reasons for doing it the way you have - like maybe selecting parent elements first is a source of flaky tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes for three tickets: EES-5430, EES-5431, and EES-5432.
As part of these tickets, UI tests have been developed based on the following acceptance criteria:
Please note that this PR is dependent on PR The changes in this PR cannot be merged into the dev branch until PR has been successfully merged.