EES-5416 Fix release files not being unlinked when draft data set versions deleted #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
force-pushed
the
ees-5416
branch
2 times, most recently
from
929aaef to
2a3c8fa
Compare
benoutram
reviewed
Aug 19, 2024
...on.ExploreEducationStatistics.Public.Data.Processor/Services/DataSetVersionMappingService.cs
Outdated
Show resolved
Hide resolved
...on.ExploreEducationStatistics.Public.Data.Processor/Services/DataSetVersionMappingService.cs
Outdated
Show resolved
Hide resolved
...on.ExploreEducationStatistics.Public.Data.Processor/Services/DataSetVersionMappingService.cs
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Services/Public.Data/DataSetVersionMappingService.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Services/Public.Data/DataSetVersionMappingService.cs
Outdated
Show resolved
Hide resolved
...onStatistics.Admin.Tests/Controllers/Api/Public.Data/DataSetVersionMappingControllerTests.cs
Outdated
Show resolved
Hide resolved
...onStatistics.Admin.Tests/Controllers/Api/Public.Data/DataSetVersionMappingControllerTests.cs
Outdated
Show resolved
Hide resolved
...onStatistics.Admin.Tests/Controllers/Api/Public.Data/DataSetVersionMappingControllerTests.cs
Show resolved
Hide resolved
...tics.Public.Data.Processor.Tests/Functions/ProcessNextDataSetVersionMappingsFunctionTests.cs
Outdated
Show resolved
Hide resolved
benoutram
approved these changes
Aug 19, 2024
ntsim
force-pushed
the
ees-5416
branch
2 times, most recently
from
bcaa881 to
8d5ab2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
ReleaseFileswould continue to reference draft data set versions after they had been deleted. This was due to a couple of issues:ReleaseFile.PublicApiDataSetVersioncolumn as well. We now update this when the version number changes.ReleaseFile.PublicApiDataSetVersion. We were querying with the 'public' version number (using non-standardmajor.minor), whereas thePublicApiDataSetVersionis stored with a standard semversion number (usingmajor.minor.patch).To help differentiate between these two version numbers better we've made the following changes to
DataSetVersion:Versiongetter is nowPublicVersion(themajor.minornumber)FullSemanticVersionmethod is nowSemVersion(themajor.minor.patchnumber)Breaking changes⚠️
As part of this, the blob / file storage path has been changed to use the semversion, rather than the public version. This is a breaking change to existing file paths on dev.
Existing API data set versions will be affected until we clear down the files, otherwise, new API data set versions should work.
Why have patch version numbers?
Currently, we don't use patch version numbers, but we may need these in the future so we're trying to support them as early as possible in case.
One potential use case are data file replacements where we may want to update the underlying data. A data replacement could be considered a bug fix for data and hence has parallels with patch versions.
Replacements are currently not supported by API data sets, but they will be considered further in post-MVP.