Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EES-5382 use key vault RBAC for public api #5144

Merged
merged 3 commits into from
Aug 14, 2024
Merged

EES-5382 use key vault RBAC for public api #5144

merged 3 commits into from
Aug 14, 2024

Conversation

duncan-at-hiveit
Copy link
Collaborator

This PR:

  • returns template.json back to its original state before EES-5387 work began
  • adds a new keyVaultRoleAssignments.bicep module
  • uses this instead of access policies to grant KV permissions to the Function App

If this all works, I'll also make this change in the "automating App Gateway" PR as well.

@duncan-at-hiveit duncan-at-hiveit merged commit b5bfc60 into dev Aug 14, 2024
3 of 7 checks passed
@duncan-at-hiveit duncan-at-hiveit deleted the EES-5382-use-key-vault-rbac-for-public-api branch August 14, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-hive jack-hive jack-hive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncan-at-hiveit @jack-hive