-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EES-5373: Remove FullTableQuery.BoundaryLevel #5119
Conversation
726077d
to
6df7a9d
Compare
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/TableBuilderController.cs
Outdated
Show resolved
Hide resolved
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Threading.Tasks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an issue to raise here with the rest of the team because it looks like when organising imports Visual Studio is organising them alphabetically and Rider is doing the same but with System imports first.
That adds up to quite a few extra lines to review in PR's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the rationale for System
being first when the other imports are alphabetical? This ticket references the option being added to Rider - the same option is available on VS but is disabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be the default option in Rider, and up until recently all team members used Rider, so a large percentage of the code will have System
imports ordered first.
Taken from StyleCop analyzer, the rationale for ordering System
imports first is:
Placing all System using directives at the top of the using directives can make the code cleaner and easier to read, and can help make it easier to identify the namespaces that are being used by the code.
I've put this as an item to discuss at the team meeting as it turns out we can try and enforce this an EditorConfig rule one way or the other depending on what we decide.
src/GovUk.Education.ExploreEducationStatistics.Common/Requests/QueryRequests.cs
Show resolved
Hide resolved
...Uk.Education.ExploreEducationStatistics.Data.Services.Tests/SubjectResultMetaServiceTests.cs
Outdated
Show resolved
Hide resolved
...ucation.ExploreEducationStatistics.Data.Services.Tests/TableBuilderServicePermissionTests.cs
Outdated
Show resolved
Hide resolved
...src/pages/release/datablocks/components/chart/reducers/__tests__/chartBuilderReducer.test.ts
Outdated
Show resolved
Hide resolved
...on-statistics-admin/src/pages/release/datablocks/__tests__/ReleaseDataBlockEditPage.test.tsx
Outdated
Show resolved
Hide resolved
CancellationToken cancellationToken = default) | ||
{ | ||
return await _dataBlockService | ||
.GetDataBlockVersionForRelease(releaseVersionId: releaseVersionId, dataBlockParentId: dataBlockParentId) | ||
.OnSuccess(dataBlockVersion => GetReleaseDataBlockResults(dataBlockVersion, cancellationToken)) | ||
.OnSuccess(dataBlockVersion => GetReleaseDataBlockResults(dataBlockVersion, boundaryLevelId, cancellationToken)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth checking formatting on this file for long lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I remember that we've chatted about this before. Might be worth chatting to @jack-hive to see if he's found a solution? I've added a note to the team meeting board to discuss the differences between IDE's when formatting long lines.
src/GovUk.Education.ExploreEducationStatistics.Data.Api/Controllers/TableBuilderController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.Api/Controllers/TableBuilderController.cs
Outdated
Show resolved
Hide resolved
…"undefined" from type definition.
On the back end Admin and Data API services,
FullTableQueryRequest
/FullTableQuery
are being used by the frond end to execute a table query and optionally specify any boundary level data which should be returned so that for content page map charts, the boundary level data can be fetched and maps can be rendered.
The front end should be responsible for including the
BoundaryLevel
in the request if boundary level data should be returned, i.e. because boundary level data is needed for rendering a map chart.This PR moves the property from the query into a separate parameter.