EES-5288 Fix ui test failure #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Above issue got fixed : |
…-education-statistics into EES-5288
mmyoungman
approved these changes
Aug 2, 2024
| @@ -115,8 +115,12 @@ Add text block with content to Test section two | |||
| user adds text block to editable accordion section Test section two ${RELEASE_CONTENT_EDITABLE_ACCORDION} | |||
| user adds content to autosaving accordion section text block Test section two 1 | |||
| ... Test section two text ${RELEASE_CONTENT_EDITABLE_ACCORDION} | |||
| user scrolls to accordion section View related dashboard(s) id:data-accordion | |||
There was a problem hiding this comment.
I'll still approve, but I don't understand why this scrolling is necessary before reloading the page?
If we're reloading the page, I wouldn't expect scrolling to an element first to have any effect.
There was a problem hiding this comment.
What I observed is sometimes page is getting frozen intermittently in pipelines. There are couple of issues behind the failure - 1 scrolling issue and 2 stale element issue. Anyway, I will try vice versa of both the steps, if it works then I will push the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and fixes the issue with the 'View Related Dashboards' accordion not opening properly