EES-4367 generate api data set preview tokens #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
requested changes
Aug 1, 2024
src/explore-education-statistics-admin/src/contexts/ConfigContext.tsx
Outdated
Show resolved
Hide resolved
...lore-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetPreviewTokenPage.tsx
Outdated
Show resolved
Hide resolved
...lore-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetPreviewTokenPage.tsx
Outdated
Show resolved
Hide resolved
...lore-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetPreviewTokenPage.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/components/CopyLinkButton.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/components/CopyLinkButton.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/components/CopyLinkButton.tsx
Outdated
Show resolved
Hide resolved
| </Button> | ||
| } | ||
| > | ||
| <div className={className}> |
There was a problem hiding this comment.
Do we need the extra div? Can't this be combined with the child container div?
There was a problem hiding this comment.
It provides a container for the whole component so you can do things like add margin around it, the child container div doesn't include the message when it's inline.
src/explore-education-statistics-common/src/components/CopyLinkButton.tsx
Outdated
Show resolved
Hide resolved
ntsim
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to generate, view and revoke API data set preview tokens.
I've added
apiBaseUrlandapiDocsUrlto the admin config, but they aren't defined however they get defined in the back end yet, and may end up being called other things.