Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5112 - fixing startup issue in Admin when Public DB is not present #5037

Merged
merged 1 commit into from
Jul 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/GovUk.Education.ExploreEducationStatistics.Admin/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using GovUk.Education.ExploreEducationStatistics.Admin.Hubs.Filters;
using GovUk.Education.ExploreEducationStatistics.Admin.Migrations.Custom;
using GovUk.Education.ExploreEducationStatistics.Admin.Models;
using GovUk.Education.ExploreEducationStatistics.Admin.Requests.Public.Data;
using GovUk.Education.ExploreEducationStatistics.Admin.Security;
using GovUk.Education.ExploreEducationStatistics.Admin.Security.AuthorizationHandlers;
using GovUk.Education.ExploreEducationStatistics.Admin.Services;
Expand Down Expand Up @@ -446,7 +447,6 @@ public virtual void ConfigureServices(IServiceCollection services)
services.AddTransient<IRedirectsService, RedirectsService>();
services.AddTransient<IDataSetCandidateService, DataSetCandidateService>();
services.AddTransient<IPostgreSqlRepository, PostgreSqlRepository>();
services.AddTransient<IDataSetVersionMappingService, DataSetVersionMappingService>();

services.AddHttpClient<IProcessorClient, ProcessorClient>((provider, httpClient) =>
{
Expand All @@ -459,6 +459,7 @@ public virtual void ConfigureServices(IServiceCollection services)
{
services.AddTransient<IDataSetService, DataSetService>();
services.AddTransient<IDataSetVersionService, DataSetVersionService>();
services.AddTransient<IDataSetVersionMappingService, DataSetVersionMappingService>();
}
else
{
Expand All @@ -471,6 +472,7 @@ public virtual void ConfigureServices(IServiceCollection services)
provider.GetRequiredService<IUserService>()));

services.AddTransient<IDataSetVersionService, NoOpDataSetVersionService>();
services.AddTransient<IDataSetVersionMappingService, NoOpDataSetVersionMappingService>();
}

services.AddTransient<INotificationClient>(s =>
Expand Down Expand Up @@ -790,4 +792,28 @@ public Task<Either<ActionResult, Unit>> DeleteVersion(
return Task.FromResult(new Either<ActionResult, Unit>(Unit.Instance));
}
}

internal class NoOpDataSetVersionMappingService : IDataSetVersionMappingService
{
public Task<Either<ActionResult, LocationMappingPlan>> GetLocationMappings(
Guid nextDataSetVersionId,
CancellationToken cancellationToken = default)
=> throw new NotImplementedException();

public Task<Either<ActionResult, BatchLocationMappingUpdatesResponseViewModel>> ApplyBatchLocationMappingUpdates(
Guid nextDataSetVersionId,
BatchLocationMappingUpdatesRequest request,
CancellationToken cancellationToken = default)
=> throw new NotImplementedException();

public Task<Either<ActionResult, FilterMappingPlan>> GetFilterMappings(
Guid nextDataSetVersionId,
CancellationToken cancellationToken = default)
=> throw new NotImplementedException();

public Task<Either<ActionResult, BatchFilterOptionMappingUpdatesResponseViewModel>> ApplyBatchFilterOptionMappingUpdates(Guid nextDataSetVersionId,
BatchFilterOptionMappingUpdatesRequest request,
CancellationToken cancellationToken = default) =>
throw new NotImplementedException();
}
}