EES-5170: Update geospatial boundary data import process to handle GeoJSON files #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjonesdev
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
mmyoungman and
amyb-hiveit
mmyoungman
requested changes
Jun 24, 2024
src/GovUk.Education.ExploreEducationStatistics.Common/Utils/BoundaryDataUtils.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryDataService.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.Model/Repository/BoundaryLevelRepository.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common/Utils/BoundaryDataUtils.cs
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/bau/BoundaryDataPage.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/bau/BoundaryDataPage.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/bau/BoundaryDataUploadPage.tsx
Outdated
Show resolved
Hide resolved
benoutram
reviewed
Jun 26, 2024
...ucation.ExploreEducationStatistics.Admin/ViewModels/Statistics/BoundaryLevelUpdateRequest.cs
Outdated
Show resolved
Hide resolved
...ucation.ExploreEducationStatistics.Admin/ViewModels/Statistics/BoundaryLevelUpdateRequest.cs
Outdated
Show resolved
Hide resolved
...ucation.ExploreEducationStatistics.Admin/ViewModels/Statistics/BoundaryLevelUpdateRequest.cs
Outdated
Show resolved
Hide resolved
...oreEducationStatistics.Admin.Tests/Controllers/Api/Statistics/BoundaryDataControllerTests.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryLevelService.cs
Outdated
Show resolved
Hide resolved
...k.Education.ExploreEducationStatistics.Admin/ViewModels/Statistics/BoundaryLevelViewModel.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Startup.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Startup.cs
Outdated
Show resolved
Hide resolved
...k.Education.ExploreEducationStatistics.Admin/ViewModels/Statistics/BoundaryLevelViewModel.cs
Outdated
Show resolved
Hide resolved
benoutram
requested changes
Jun 28, 2024
...ion.ExploreEducationStatistics.Admin/GovUk.Education.ExploreEducationStatistics.Admin.csproj
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryDataService.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common/Utils/BoundaryDataUtils.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin.Tests/Services/BoundaryDataServiceTests.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryDataService.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.ViewModels/LocationViewModelBuilder.cs
Outdated
Show resolved
Hide resolved
...Uk.Education.ExploreEducationStatistics.Data.Services.Tests/SubjectResultMetaServiceTests.cs
Outdated
Show resolved
Hide resolved
...Uk.Education.ExploreEducationStatistics.Data.Services.Tests/LocationViewModelBuilderTests.cs
Outdated
Show resolved
Hide resolved
mmyoungman
requested changes
Jul 4, 2024
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryLevelService.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Startup.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Startup.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.ViewModels/LocationViewModelBuilder.cs
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/bau/BoundaryDataPage.tsx
Outdated
Show resolved
Hide resolved
benoutram
reviewed
Jul 5, 2024
src/GovUk.Education.ExploreEducationStatistics.Data.Model/BoundaryData.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common/Utils/BoundaryDataUtils.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.Model/BoundaryData.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common/Model/Data/BoundaryLevel.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common/Model/Data/BoundaryLevel.cs
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Admin/Controllers/Api/Statistics/BoundaryDataController.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Data.Model/Repository/BoundaryLevelRepository.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/BoundaryLevelService.cs
Outdated
Show resolved
Hide resolved
tomjonesdev
force-pushed
the
EES-5170
branch
4 times, most recently
from
f2d4068 to
01e0b26
Compare
mmyoungman
requested changes
Jul 9, 2024
...loreEducationStatistics.Data.Model/Migrations/20240708101105_EES5170_AddBoundaryDataTable.cs
Show resolved
Hide resolved
...reEducationStatistics.Admin.Tests/Controllers/Api/Statistics/BoundaryLevelControllerTests.cs
Show resolved
Hide resolved
...reEducationStatistics.Admin.Tests/Controllers/Api/Statistics/BoundaryLevelControllerTests.cs
Outdated
Show resolved
Hide resolved
...ducationStatistics.Admin.Tests/GovUk.Education.ExploreEducationStatistics.Admin.Tests.csproj
Outdated
Show resolved
Hide resolved
benoutram
reviewed
Jul 9, 2024
src/GovUk.Education.ExploreEducationStatistics.Common/Utils/BoundaryDataUtils.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Requests/BoundaryLevelCreateRequest.cs
Outdated
Show resolved
Hide resolved
...reEducationStatistics.Admin.Tests/Controllers/Api/Statistics/BoundaryLevelControllerTests.cs
Outdated
Show resolved
Hide resolved
...reEducationStatistics.Admin.Tests/Controllers/Api/Statistics/BoundaryLevelControllerTests.cs
Outdated
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Common.Tests/Utils/BoundaryDataUtilsTests.cs
Outdated
Show resolved
Hide resolved
benoutram
reviewed
Jul 9, 2024
src/GovUk.Education.ExploreEducationStatistics.Data.Model/Repository/GeoJsonRepository.cs
Outdated
Show resolved
Hide resolved
added 4 commits
July 9, 2024 16:41
…eoJSON file processing and BoundaryLevel management, replace GeoJson references with BoundaryData.
mmyoungman
approved these changes
Jul 9, 2024
benoutram
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current process for implementing new geospatial boundary data requires a developer to complete several manual steps, using various tools, to convert shapefile data into the GeoJSON format used by EES each time new data is published.
This work adds a section to the administrative portal which allows BAU users to manage the data themselves, removing the dependency on a developer and streamlining the overall process. This section allows users to view the current levels, amend their labels, and upload new data files as they become available.