EES-4993 Move PublicApiDataSet* columns from Files to ReleaseFiles
#4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Tsim <nicholastsim@gmail.com>
jack-hive
approved these changes
Jun 18, 2024
Comment on lines
+419
to
+424
| entity.HasIndex(rf => new | ||
| { | ||
| rf.ReleaseVersionId, | ||
| rf.FileId, | ||
| }) | ||
| .IsUnique(); |
There was a problem hiding this comment.
I'm guessing this is unrelated to this PR but we just wanted to add this in because it should have always been there?
There was a problem hiding this comment.
Yep, this is just to add a unique constraint that should have been there in the first place!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
PublicApiDataSetIdandPublicApiDataSetVersioncolumns from the content DB'sFilestable toReleaseFiles.This fixes an issue where creating a draft API data set for a
ReleaseFilein an amendment can immediately show in the Data Catalogue as an API data set. This was due to thePublicApiDataSet*columns previously being on theFilestable, meaning any changes would be shared between allReleaseFilessharing the sameFile.PublicApiDataSet*columns for any amendmentReleaseFilesthat have already been created with this issue.