Permit uppercase characters in URL path without redirecting #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
approved these changes
Jun 11, 2024
sambiramairelogic
deleted the
EES-5222/subscription-verification-lowercasing-bug
branch
jack-hive
pushed a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new subscription-verification page contains the verification token as part of its route. This token is case sensitive.
I've recently refactored the code that implements SEO redirects, and because the redirectService is lowercasing any Content API redirects it finds, I chose to be consistent in the SEO redirects.
This, understandably, is a pretty fatal but entirely predictable change for the subscription-verification page 🤦
(If we care about the lowercasing, we could be more explicit about the path itself and still lowercase any parts of the path that aren't the token itself, but I actually don't think it's necessary).