Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-4996 Fix various test issues from data catalogue work #4874

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

ntsim
Copy link
Collaborator

@ntsim ntsim commented May 20, 2024

This PR:

  • Fixes inefficient findByRole selectors being used in unit tests
  • Fixes CSP connect-src URLs being incorrect - these require a trailing slash to work correctly. This currently prevents fetching data from most of the APIs in the public frontend when running in production mode.
  • Fixes missing UrlContainer testids causing lots of failures across Robot tests

@ntsim ntsim changed the title EES-4996 Fix expensive findByRole selectors in DataSetFileApiVersionHistory EES-4996 Fix various testing issues from data catalogue work May 21, 2024
@ntsim ntsim changed the title EES-4996 Fix various testing issues from data catalogue work EES-4996 Fix various test issues from data catalogue work May 21, 2024
@ntsim ntsim requested a review from sambiramairelogic May 21, 2024 10:01
@ntsim ntsim merged commit 656a906 into dev May 21, 2024
7 checks passed
@ntsim ntsim deleted the EES-4996 branch May 21, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants