EES-4856 Add csv preview, variables, and footnotes to GetDataSetFile #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjonesdev
reviewed
May 17, 2024
src/explore-education-statistics-frontend/src/modules/data-catalogue/DataSetFilePage.tsx
Outdated
Show resolved
Hide resolved
tomjonesdev
approved these changes
May 17, 2024
|
I've put a do not merge because I want to merge #4871 and resolve any conflicts here, rather than vice versa. |
mmyoungman
force-pushed
the
EES-4856
branch
2 times, most recently
from
619c01a to
0ccf518
Compare
mmyoungman
force-pushed
the
EES-4856
branch
2 times, most recently
from
9087812 to
47ebbb6
Compare
tomjonesdev
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes additional data in the response returned by
DataSetFileService#GetDataSetFile:To have these changes work with integration tests,
Testcontainers.Azuritehas been added as a dependency to theContent.Api.Testsproject. This is used to locally spins up a docker container which are then used by integration tests.The
appsettings.IntegrationTest.jsonfile has also been added to theContent.Api.Testsproject. This was done to ensure that if someone is running the integration tests while they have the data-storage docker container running in the background, the tests don't pass due to reliance on the data-storage container.I've tested the fetching of the first five rows of the data set CSV locally to ensure it's performance is acceptable, and it seemed fine. I've held off doing more exhaustive testing as it'll be easy for us to test this once it's deployed on Prod by visiting the currently hidden Data set details pages - and that'll be testing against current Prod data which seems superior anyway.
I've also moved
DataSetFileMetaViewModelintoDatSetFileFileViewModel, since the meta is related to a specific data set file, unlike footnotes, for example, that are linked to a specific data set file/release version combo.