EES-4996 add api info to data set page #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
mmyoungman,
sambiramairelogic and
jack-hive
amyb-hiveit
force-pushed
the
EES-4996
branch
2 times, most recently
from
444cfe2 to
84a9b9e
Compare
ntsim
force-pushed
the
EES-4996
branch
3 times, most recently
from
a32cdaf to
4648334
Compare
This mostly moves away from using test IDs to a required `id` prop. Additionally, we've updated the labelling to be the correct 'URL' acronym instead of 'Url'.
ntsim
force-pushed
the
EES-4996
branch
2 times, most recently
from
cf1ae2b to
971e263
Compare
This refactors section styling so that `DataSetFilePageSection` is able to apply consistent spacing between each section without having to manually apply margins and paddings by eye to individual elements.
This changes `DataSetFilePage` to be server-side rendered as its not necessary for the page to be client-side driven by React Query.
ntsim
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the initial API data set info to the data set page: