EES-5085 Fix incorrect slugs for updated publication titles with dashes and spaces #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
requested review from
benoutram,
duncan-at-hiveit,
mmyoungman,
sambiramairelogic,
saicharan2789,
tomjonesdev,
sabine-volceka and
jack-hive
mmyoungman
approved these changes
Apr 25, 2024
tomjonesdev
approved these changes
Apr 25, 2024
|
If you're keen, you could add the corresponding test to the backend - I think it won't have it. Edit: It doesn't - |
This failure only occurs when there are duplicated publication titles in the same test run, which typically only occurs when running all the tests in parallel.
mmyoungman
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect slugs being shown when updating publication titles. Previously, titles like
My test - publicationwould result in a slug likemy-test---publication. With the fix, this is nowmy-test-publication.As part of this, we've also updated the
publish_methodology_publication_update.robotsuite, which would previously fail on parallel test runs due to having a publication title that is a duplicate of another test suite (publish_publication_update.robot). It's likely that the publication title used inpublish_methodology_publication_update.robothad previously been non-standard to avoid this slug issue.