Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GovUk-Frontend warnings #4756

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

sambiramairelogic
Copy link
Contributor

Each time we start the frontend project we're currently getting warnings produced by the GovUk Frontend package because we're using a font value that will be deprecated in the next version. Following the guidance here - https://design-system.service.gov.uk/get-started/new-type-scale/ - this PR updates the font to the next lowest value.

button-after-change button-after-change-mobile govuk-warning

Copy link
Collaborator

@amyb-hiveit amyb-hiveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the new data catalogue filters, where the type is shown, a bit big, but it's under a feature flag so I'm happy to leave it for now and I'll tweak it when I go back to data catalogue work.

@sambiramairelogic sambiramairelogic force-pushed the EES-XXXX/comply-with-gov-uk-front-guidelines branch from 7ad47e7 to b867929 Compare April 16, 2024 12:44
@sambiramairelogic sambiramairelogic merged commit 7621f78 into dev Apr 16, 2024
2 of 3 checks passed
@sambiramairelogic sambiramairelogic deleted the EES-XXXX/comply-with-gov-uk-front-guidelines branch April 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants