EES-5056 Adding relationship from the Content DB's Files table to the Public API DB's DataSetVersion table #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
approved these changes
Apr 10, 2024
benoutram
approved these changes
Apr 12, 2024
benoutram
reviewed
Apr 12, 2024
| @@ -22,6 +22,8 @@ public class File : ICreatedTimestamp<DateTime?> | |||
|
|
|||
| public int? DataSetFileVersion { get; set; } | |||
|
|
|||
| public Guid? PublicDataSetVersionId { get; set; } | |||
There was a problem hiding this comment.
I think it would be a good idea to add an index to this field by changing ContentDbContext with something like entity.HasIndex(e => e.PublicDataSetVersionId);
There was a problem hiding this comment.
Yes, it 100% would be! I intended on doing this and forgot.
Added it now :)
… Public API DB's DataSetVersion table
benoutram
approved these changes
Apr 15, 2024
sambiramairelogic
pushed a commit
that referenced
this pull request
Apr 24, 2024
… Public API DB's DataSetVersion table (#4739) * EES-5056 Adding relationship from the Content DB's Files table to the Public API DB's DataSetVersion table * EES-5056 Adding index to `PublicDataSetVersionId` in the `Files` table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is to implement the database relationship so that CSV Datasets and Public API datasets can be linked - and then used across the Public API workstream.
The proposed solution is to add a new
PublicDataSetVersionIdcolumn to theFilestable in the Content DB. This links to the Id primary key in theDataSetVersionstable in the Public API DB.The
DataSetVersionstable in the Public API DB currently already has the inverse relationship in the form of aCsvFileIdcolumn which corresponds to the Id primary key column of theFilestable in the Content DB.