Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKS: More specific VPC CNI reference, to avoid buggy AWS CNI #57

Merged
merged 1 commit into from
Oct 7, 2019
Merged

EKS: More specific VPC CNI reference, to avoid buggy AWS CNI #57

merged 1 commit into from
Oct 7, 2019

Conversation

abstrask
Copy link
Contributor

@abstrask abstrask commented Oct 7, 2019

Previous implementation did not allow for specifying patch version of CNI, which presented a problem: aws/amazon-vpc-cni-k8s#641.

Now:

  • Able to specify x.y.z version
  • Recommended VPC CNI version changed to 1.5.3

@abstrask abstrask requested a review from wcarlsen October 7, 2019 13:10
HenrikStanley
HenrikStanley approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@HenrikStanley HenrikStanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this should help us prevent issues like the CNI version has errors.

@HenrikStanley HenrikStanley merged commit 44d1985 into master Oct 7, 2019
@HenrikStanley HenrikStanley deleted the eks-specific-cni-version branch February 14, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikStanley HenrikStanley HenrikStanley approved these changes

@wcarlsen wcarlsen Awaiting requested review from wcarlsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abstrask @HenrikStanley