Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation for pytest coverage #40

Merged
merged 6 commits into from
Jul 13, 2022
Merged

Fix installation for pytest coverage #40

merged 6 commits into from
Jul 13, 2022

Conversation

KPLauritzen
Copy link
Contributor

@KPLauritzen KPLauritzen commented Jul 13, 2022 •
edited
Loading

Remove requirements files, and change method for getting pytest coverage

@github-actions
Copy link

github-actions bot commented Jul 13, 2022 •
edited
Loading

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.5-final-0 -----------

Name Stmts Miss Cover
dfds_ds_toolbox/analysis/plotting.py 110 32 71%
dfds_ds_toolbox/analysis/plotting_utils.py 124 114 8%
dfds_ds_toolbox/exeptions.py 0 0 100%
dfds_ds_toolbox/feature_selection/feat_selector.py 141 21 85%
dfds_ds_toolbox/logging/logging.py 27 0 100%
dfds_ds_toolbox/model_selection/model_selection.py 31 3 90%
dfds_ds_toolbox/profiling/profiling.py 19 0 100%
TOTAL 452 170 62%
======================= 27 passed, 52

@KPLauritzen KPLauritzen requested a review from a team July 13, 2022 10:08
@KPLauritzen KPLauritzen marked this pull request as ready for review July 13, 2022 10:08
@KPLauritzen KPLauritzen changed the title Fix installation for pytester-coverage Fix installation for pytest coverage Jul 13, 2022
pacanada
pacanada reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@pacanada pacanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements files are not used anymore? is related to this PR or just some legacy stuff?

@KPLauritzen
Copy link
Contributor Author

The requirements files are not used anymore? is related to this PR or just some legacy stuff?

@pacanada After changing build system to poetry, we don't need them anymore.

@KPLauritzen KPLauritzen merged commit d19dd16 into main Jul 13, 2022
@KPLauritzen KPLauritzen deleted the b/code-coverage-install branch July 13, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacanada pacanada pacanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KPLauritzen @pacanada