Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate RegFeatureSelector and the sub-methods it calls. #10

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Deprecate RegFeatureSelector and the sub-methods it calls. #10

merged 1 commit into from
Feb 3, 2022

Conversation

KPLauritzen
Copy link
Contributor

Closes #8

@KPLauritzen
Copy link
Contributor Author

The decorator adds a DEPRECATED warning in the docs as well. Cool.
image

@KPLauritzen KPLauritzen marked this pull request as ready for review February 2, 2022 15:30
@KPLauritzen KPLauritzen requested review from martimors and a team February 2, 2022 15:30
@KPLauritzen KPLauritzen added the documentation Improvements or additions to documentation label Feb 2, 2022
martimors
martimors approved these changes Feb 3, 2022
View reviewed changes
Copy link

@martimors martimors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@KPLauritzen KPLauritzen merged commit 9c13a44 into main Feb 3, 2022
@KPLauritzen KPLauritzen deleted the refactor/deprecate_feat_selector branch February 3, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martimors martimors martimors approved these changes

@pacanada pacanada pacanada approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We are duplicating functionality from sklearn
3 participants
@KPLauritzen @pacanada @martimors