Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the correct start and end indices #1271

Closed
wants to merge 3 commits into from
Closed

Point to the correct start and end indices #1271

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25a97e5
Point to the correct start and end indices
zhenyanghua Apr 13, 2021
35bdb11
disabled blobs reset
zhenyanghua Apr 24, 2021
ca986b1
Merge branch 'master' into patch-1
dfahlander Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions addons/dexie-export-import/src/tson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,15 @@ TSON.finalize = async (items?: any[]) => {
const typeSpec = TSON.types[typeName];
if (typeSpec && typeSpec.finalize) {
const b = Dexie.getByKeyPath(item, arrayType ? "$." + keyPath : keyPath);
typeSpec.finalize(b, allChunks.slice(b.start, b.end));
typeSpec.finalize(b, allChunks.slice(b.data?.start, b.data?.end));
}
}
}
}
}
// Free up memory
blobsToAwait = [];
// Todo - this is the problematic one that causes the blobs to be reset everytime the `finalize` is
// called, where the chunks slicing are happening, which causes the data slicing with the wrong indices.
// need to figure out a different way to GC.
// blobsToAwait = [];
}