Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTPS server listener regression #2018

Closed

Conversation

nabokihms
Copy link
Member

Signed-off-by: m.nabokikh maksim.nabokikh@flant.com

Overview

  • New abstraction to run and shutdown HTTP server gracefully
  • Add optional support for the TLS encryption

What this PR does / why we need it

Fix of the regression of #1963
The HTTPS server of dex built from the master branch listens on a port without TLS encryption.

Special notes for your reviewer

Does this PR introduce a user-facing change?

It is the fix for the previous PR with a new feature, so we should not add anything new to the release message.

NONE

Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms added this to the v2.28.0 milestone Feb 25, 2021
@nabokihms nabokihms self-assigned this Feb 25, 2021
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully agree with this way. Also, I don't see the actual bug what caused the HTTPS server to stop working. Is it because we always called Serve and never ServeTLS?

cmd/dex/serve.go Show resolved Hide resolved
@sagikazarmark
Copy link
Member

Fixed in #2019

@nabokihms nabokihms removed their assignment Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants