Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Gracefully shutdown server #1541

Closed
wants to merge 1 commit into from
Closed

WIP: Gracefully shutdown server #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cmd/dex/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,16 @@ func serve(cmd *cobra.Command, args []string) error {
}()
}()
}

return <-errc
stop := make(chan os.Signal, 1)
signal.Notify(stop, os.Interrupt, syscall.SIGTERM)
select {
case err = <-errc:
return err //there is error in stating service, return immediately
case <-stop:
//TODO: stop http/gRPC server in grachful style as well.
s.Close()
}
return nil
}

var (
Expand Down