show "back" link for password connectors #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Nov 10, 2017
web/templates/password.html
Outdated
| @@ -25,6 +25,11 @@ <h2 class="theme-heading">Log in to Your Account</h2> | |||
| <button tabindex="3" id="submit-login" type="submit" class="dex-btn theme-btn--primary">Login</button> | |||
|
|
|||
| </form> | |||
| {{ if .BackLink }} | |||
| <div class="theme-link-back"> | |||
| <a class="dex-subtle-text" href="javascript:history.back()">Select another Connector</a> | |||
There was a problem hiding this comment.
"Select another login method."
|
One nit, otherwise lgtm |
srenatus
force-pushed
the
sr/back-button-for-password-template
branch
from
b32debd to
4307d7c
Compare
|
Fixed nit, rebased. 😃 |
This way, the user who has selected, say, "Log in with Email" can make up their mind, and select a different connector instead. However, if there's only one connector set up, none of this makes sense -- and the link will thus not be displayed. Signed-off-by: Stephan Renatus <srenatus@chef.io>
srenatus
force-pushed
the
sr/back-button-for-password-template
branch
from
4307d7c to
41f663f
Compare
This was referenced Nov 14, 2017
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…ord-template show "back" link for password connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the user who has selected, say, "Log in with Email" can make up
their mind, and select a different connector instead.
However, if there's only one connector set up, none of this makes sense -- and
the link will thus not be displayed.
Fixes #1115.