Skip to content

Commit

Permalink
fix(toolbar): incorrect height for soft-keyboards
Browse files Browse the repository at this point in the history
* On some devices, the onboard keyboard (soft-keyboard) causes the CSS orientation to change from portrait to landscape.
  This causes the toolbar to turn smaller than it should be. As for now, relying on @media orientation should be avoided.

* Libraries like MDL or Polymer also ignore the landscape orientation check, and only change heights for mobile and desktop.

Fixes angular#3233
  • Loading branch information
devversion committed Feb 26, 2017
1 parent c203589 commit 2187c08
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/lib/toolbar/toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,10 @@ $mat-toolbar-padding: 16px !default;
// Set the default height for the toolbar.
@include mat-toolbar-height($mat-toolbar-height-desktop);

// Specific height for mobile devices in portrait mode.
@media ($mat-xsmall) and (orientation: portrait) {
// As per specs, mobile devices will use a different height for toolbars than for desktop.
// The height for mobile landscape devices has been ignored since relying on `@media orientation`
// is causing issues on devices with a soft-keyboard.
// See: https://material.io/guidelines/layout/structure.html#structure-app-bar
@media ($mat-xsmall) {
@include mat-toolbar-height($mat-toolbar-height-mobile-portrait);
}

// Specific height for mobile devices in landscape mode.
@media ($mat-small) and (orientation: landscape) {
@include mat-toolbar-height($mat-toolbar-height-mobile-landscape);
}

0 comments on commit 2187c08

Please sign in to comment.