Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableInitialSync feature flag #2835

Conversation

rcelestino
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
Partially resolves #1218 adding support to disable completely the initial sync

Please provide a short message that should be published in the DevSpace release notes
Enhance the configuration capabilities of DevSpace to enable the possibility of disabling the initial sync, similar to how you can currently disable the upload or download.

What else do we need to know?
There are use cases where syncing is required only for files changed after the development or sync process has been initiated, rather than fully synchronizing the remote or local repository.

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2953f49
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/6619c456d876710008e86a56
😎 Deploy Preview https://deploy-preview-2835--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Instead of adding a new flag, what would you think of adding another InitialSyncStrategy, named none or disabled?

This should reduce the number of changes. The docs would need to be updated here to document the new strategy.

Additionally, an e2e test would help to avoid regressions in the future. I can assist if needed, since the initial sync strategies aren't well tested at the moment.

@rcelestino rcelestino force-pushed the rcelestino/improve_featureflag_disableinitialsync branch 3 times, most recently from 9e0d227 to e8ae032 Compare April 12, 2024 22:53
Adding support to disable the initial sync using the same initialSync strategy configuration.

Signed-off-by: Roberto Celestino <rcelestino@gmail.com>
@rcelestino rcelestino force-pushed the rcelestino/improve_featureflag_disableinitialsync branch from e8ae032 to 2953f49 Compare April 12, 2024 23:31
@rcelestino
Copy link
Contributor Author

@lizardruss changed and added e2e.

dev:app-meta sync Start syncing dev:app-meta sync Sync started on: ./ <-> /code/ dev:app-meta sync Waiting for initial sync to complete dev:app-meta sync Downstream - Initial sync disabled dev:app-meta sync Upstream - Initial sync disabled dev:app-meta sync Initial sync completed dev:app-meta ssh Port forwarding started on: 9042 -> 8022

@lizardruss lizardruss merged commit dee1f18 into devspace-sh:main May 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync: disableDownload -- Syncing files to / appears that devspace still processes index for entire container
2 participants