fix: use registry token for pull secrets #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizardruss
force-pushed
the
fix-wincreds
branch
from
5239624 to
32bd30b
Compare
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
FabianKramm
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
resolves #2324
The
wincredcredential store returns an emptyusernamewhen resolving credentials. Because of this, we skip creating the pull secret since we don't have complete credentials.The solution is to provide a username of
00000000-0000-0000-0000-000000000000when using ACR, according to their docs. This issue is specific to thewincredcredential store.Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace would not create a pull secret when using
wincredcredentials store