Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEVSPACE_PROFILES variable and is_in command #2297

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

alexissellier
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Add builtin DEVSPACE_PROFILES variable containing all enabled profiles

Please provide a short message that should be published in the DevSpace release notes
Add DEVSPACE_PROFILES variable

What else do we need to know?
For now it is still a draft because the variable is an array and is "converted" into a list of string with extra [ and ]. Need to figure out how to resolve that

@alexissellier alexissellier marked this pull request as ready for review September 13, 2022 14:02
Copy link
Collaborator

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexissellier thanks for the PR! LGTM!

@FabianKramm FabianKramm merged commit 8180960 into devspace-sh:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants