Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devspace open will wait for a init container which is a sidecar #2865

Closed
nberlee opened this issue Jun 12, 2024 · 1 comment · Fixed by #2866
Closed

devspace open will wait for a init container which is a sidecar #2865

nberlee opened this issue Jun 12, 2024 · 1 comment · Fixed by #2866
Labels
kind/bug Something isn't working

Comments

@nberlee
Copy link
Contributor

nberlee commented Jun 12, 2024 •
edited
Loading

What happened?
In kubernetes 1.29 the Sidecar feature became general available. This means you have a init container which has a restartPolicy: Always runs forever, effectively as a sidecar. This is what istio uses to prevent a lot of issues

The problem is devspace open will wait for the init container to exit, therefore, devspace dev will never continue.

What did you expect to happen instead?
If restartPolicy is defined in the init container it should just continue.

How can we reproduce the bug? (as minimally and precisely as possible)
Use Kubernetes 1.29 or higher. And use a manifest like https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

devspace open wil not continue
@nberlee nberlee added the kind/bug Something isn't working label Jun 12, 2024
nberlee added a commit to nberlee/devspace that referenced this issue Jun 12, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
34b63b2 
fixes devspace-sh#2865
@nberlee nberlee mentioned this issue Jun 12, 2024
Merged
nberlee added a commit to nberlee/devspace that referenced this issue Jun 12, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
8c9484b 
fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
nberlee added a commit to nberlee/devspace that referenced this issue Jun 12, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
71e676e 
in order to support initContainer RestartPolicy I had to update client-go to 1.29

fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
nberlee added a commit to nberlee/devspace that referenced this issue Jun 12, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
67a5a35 
in order to support initContainer RestartPolicy I had to update client-go to 1.29

fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
nberlee added a commit to nberlee/devspace that referenced this issue Jun 12, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
7c629f4 
fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
@nberlee nberlee changed the title devspace dev will wait for a init container which is a sidecar devspace open will wait for a init container which is a sidecar Jun 12, 2024
nberlee added a commit to nberlee/devspace that referenced this issue Jul 10, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
c6bcf15 
fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
nberlee added a commit to nberlee/devspace that referenced this issue Jul 10, 2024
@nberlee
fix: do not wait for initContainer to exit when it is a sidecar
81d9d33 
fixes devspace-sh#2865

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
@digibeuk
Copy link

this has not been released @lizardruss could you make a new release? we need this is our organization thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not wait for initContainer to exit when it is a sidecar nberlee/devspace
2 participants
@nberlee @digibeuk