Skip to content

fix: validate_description to run on bot commits. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

codeon
Copy link
Contributor

@codeon codeon commented Jul 24, 2025

Summary

Currently the validate_description trigger doesn't run when a bot does a commit to a PR. In flow repo, we have bots automatically fixing formatting issues, or doing dummy commits. In those cases, the validate_description check is not run.
This leads to a forceful manual commit, tests re-run, and waste of time.

Related Issues

ISS-195199

Type of Change

  • Change doesn't affect products or customers
  • Bug fix (non-breaking change which fixes an issue)
  • Non-breaking change (the new functionality and code refactor do not require a migration strategy)
  • Breaking change (fix or feature that will require a migration plan for data or other services)
  • Documentation/comment update
  • Other (please describe):

Testing Procedure

Checklist

  • I used generative AI to generate this PR
  • I have self-reviewed my code for clarity and correctness
  • I have added or updated comments for complex or non-obvious logic in my code
  • I have updated relevant documentation (e.g., README, code docs)
  • My changes do not introduce new warnings or errors
  • I have added or updated tests to cover new or changed functionality
  • All tests pass locally with my changes applied

@codeon codeon requested review from devrev-jo and n-h-n as code owners July 24, 2025 17:51
@svc-devrev
Copy link

svc-devrev commented Jul 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Collaborator

@devrev-jo devrev-jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Collaborator

@devrev-jo devrev-jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@codeon codeon merged commit 631984f into main Jul 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants