feat: add the platform classifier to the native library filename #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devopvoid
requested changes
Aug 15, 2025
webrtc/src/main/java/dev/onvoid/webrtc/internal/NativeLoader.java
Outdated
Show resolved
Hide resolved
webrtc/src/main/java/dev/onvoid/webrtc/internal/NativeLoader.java
Outdated
Show resolved
Hide resolved
fix: make native platform detection more robust Co-authored-by: Alex Andres <58339654+devopvoid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Currently the project builds 6 native libraries:
webrtc-java.dllfor Windows x86_64 inwebrtc-java-$VERSION-windows-x86_64.jarlibwebrtc-java.sofor Linux x86_64 inwebrtc-java-$VERSION-linux-x86_64.jarlibwebrtc-java.sofor Linux aarch32 inwebrtc-java-$VERSION-linux-aarch32.jarlibwebrtc-java.sofor Linux aarch64 inwebrtc-java-$VERSION-linux-aarch64.jarlibwebrtc-java.dylibfor macOS x86_64 inwebrtc-java-$VERSION-macos-x86_64.jarlibwebrtc-java.dylibfor macOS aarch64 inwebrtc-java-$VERSION-macos-aarch64.jarFor a cross-platform app that doesn't ship a different package per platform, all 6 of these jars might be in the classpath together.
This means that
NativeLoadercan load the wrong one, because it just looks for a filename with an extension matching the current platform.I suggest appending the OS and architecture to the filename:
webrtc-java-windows-x86_64.dllfor Windows x86_64 inwebrtc-java-$VERSION-windows-x86_64.jarlibwebrtc-java-linux-x86_64.sofor Linux x86_64 inwebrtc-java-$VERSION-linux-x86_64.jarlibwebrtc-java-linux-aarch32.sofor Linux aarch32 inwebrtc-java-$VERSION-linux-aarch32.jarlibwebrtc-java-linux-aarch64.sofor Linux aarch64 inwebrtc-java-$VERSION-linux-aarch64.jarlibwebrtc-java-macos-x86_64.dylibfor macOS x86_64 inwebrtc-java-$VERSION-macos-x86_64.jarlibwebrtc-java-macos-aarch64.dylibfor macOS aarch64 inwebrtc-java-$VERSION-macos-aarch64.jarThen we can lookup with
webrtc-java-$OS-$ARCH, and all 6 jars can live together in the classpath - I tested it and it works.What do you think?
Thanks