fix: made RTCRtpCodecCapability's int fields optional #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I tried to use
RTCRtpTransceiver.setCodecPreferences
, with codecs fromfactory.getRtpSenderCapabilities(MediaType.VIDEO)
, but it failed with this message:This seems to be because
RTCRtpCodecCapability::toJava
andRTCRtpCodecCapability::toNative
don't preserve the capability object because the java conversion uses.value_or(0)
on thestd::optional<int>
fieldsclock_rate
andnum_channels
.(and then libwebrtc's
IsSameRtpCodec
thinks the capability changed and rejects it)I converted the
int
fields toInteger
, likeRTCRtpCodecParameters
does for the same reason, and uncommented asetCodecPreferences
that was previously causing a test to fail.The code pretty much matches with
RTCRtpCodecParameters.{java,cpp}
.What do you think? :)