-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for spaces/special characters #912
Conversation
Makes a lot of sense to me.
|
Yeah, I know - I was just too tired to resolve the merge conflict last night. :) |
As far as I can tell, I've removed "displayname" from being needed at all - I came to the opposite conclusion from what @mattstratton was saying in #861, after digging into this. People can now just set "City" as desired, and the new event script will handle it. The few places I was parsing the city value, I'm now parsing "name" to get the city slug.
It didn't turn out to be necessary to put the city slug in the data file. When updating the new event script as requested in #860, I kept it simple and parsed the entered name instead of asking the user for multiple variations.
I also think I can probably remove "friendly" as a data file element from the sample data file; it's not used, although in one place a variable is also called that.
I'm leaving "current" in the data file for now until it's totally gone and #882 is resolved.