Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduced total logo width from 100px to 95px #109

Merged
merged 1 commit into from
Apr 11, 2016
Merged

reduced total logo width from 100px to 95px #109

merged 1 commit into from
Apr 11, 2016

Conversation

kmugrage
Copy link
Contributor

For #108

I'm not sure this is the "right" way to do this compared to changing the width of the div, but reducing the total size of the logos by 5px makes them 3 wide on desktop browsers.

@kmugrage kmugrage changed the title reduced total logo width from 100px to 95px for #108 reduced total logo width from 100px to 95px Apr 11, 2016
@bridgetkromhout
Copy link
Collaborator

I am going to defer this one to @mattstratton. Agree with the notion, unsure how he'd prefer it implemented.

@mattstratton
Copy link
Member

This seems like the less elegant manner of doing it, but it also works, which is better than debating the CSS. I think it's fine for now. I'll accept it.

@mattstratton mattstratton merged commit d239fdc into devopsdays:master Apr 11, 2016
@kmugrage kmugrage deleted the reduce_logo_sizes branch May 5, 2016 19:44
benjohnson77 pushed a commit to benjohnson77/devopsdays-web that referenced this pull request May 22, 2016
yvovandoorn pushed a commit that referenced this pull request May 22, 2016
yvovandoorn pushed a commit that referenced this pull request May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants