Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu links don't appear as links #510

Closed
tgross opened this issue Jun 3, 2016 · 8 comments · Fixed by #542
Closed

Submenu links don't appear as links #510

tgross opened this issue Jun 3, 2016 · 8 comments · Fixed by #542
Assignees

Comments

@tgross
Copy link
Contributor

tgross commented Jun 3, 2016

Links in the submenus don't appear as links; they're just black text on a gray box. For example:

screen shot 2016-06-03 at 4 53 14 pm

screen shot 2016-06-03 at 4 53 01 pm

I was going to make a PR with a tweak but you're using Less and I got a bit lost trying to find where I was supposed to be. 😊 The compiled asset is http://www.devopsdays.org//css/devops.min.css and with this fix:

 .submenu h3 a {
    color: #333333;
    /* text-decoration: none; */
}

You end up with this nicer submenu:

screen shot 2016-06-03 at 4 55 05 pm

cc @bridgetkromhout as you asked me to drop a line here

@bridgetkromhout
Copy link
Collaborator

Thanks, @tgross! We have a branch going with a responsive redesign (probably landing this weekend) and then I'll chat with our site mastermind @mattstratton and figure out how best to clear up this admittedly confusing visual. I appreciate the detailed issue.

@mattstratton
Copy link
Member

Totally get where you're coming from; this is inherited from the previous design which I assume had some reason for making them not have underlines. :)

We will noodle on the change.

@bridgetkromhout
Copy link
Collaborator

I think one minimal thing we could do is make a hover-over lead to an underline appearing, much like on the program pages in the responsive redesign (I'm hovering over Ben Zvan's talk on the right):

screen shot 2016-06-04 at 3 05 35 pm

@bridgetkromhout
Copy link
Collaborator

The underlining works for me in Chrome on the front page:
screen shot 2016-06-11 at 3 18 44 pm

But it doesn't work on the site-specific pages:
screen shot 2016-06-11 at 3 18 52 pm

@yvovandoorn
Copy link
Contributor

So I spent some time debugging this and my CSS foo is at wits end. The hover action for the CSS class ID has been defined but its been overruled elsewhere as its not being triggered or interpreted by the browser (at least with the built in Chrome DevTools).

@mattstratton
Copy link
Member

Do you know the trick in Dev Tools to expose the :hover psudoclass?

@yvovandoorn
Copy link
Contributor

Yup. The trick works on the front page but not on the event headers.

On Sunday, 12 June 2016, Matt Stratton notifications@github.com wrote:

Do you know the trick in Dev Tools to expose the :hover psudoclass?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#510 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACkd_5BXbSCHJaD-zSfhHMVS2D4Aoi2iks5qLHf2gaJpZM4It594
.

Yvo van Doorn — Manager, Technical Services (EMEA)

+31 6 38 74 07 46 <+316740746> – yvo@chef.io – *my: *Linkedin
http://www.linkedin.com/in/yvovandoorn/ Twitter
https://twitter.com/yvov

CHEF

CHEF.IO http://www.chef.io/

TM

chef.io http://www.chef.io/ Blog http://www.chef.io/blog/ Facebook
https://www.facebook.com/getchefdotcom Twitter
https://twitter.com/chef Youtube https://www.youtube.com/getchef

@mattstratton
Copy link
Member

Ok so I think I fixed it, but I don't like how I had to fix it.

This actually all goes back to issues with us using <h3> tags for navigation which is semantically crap, and I'll refactor that later. Anyway, it seems that setting the text-decoration on the a element instead of on the h3 element was causing some weirdness. This is all around bad, but it now matches the way I did the CSS on the homepage, so it seems to work. I'm submitting the PR with the fix in a minute.

mattstratton added a commit that referenced this issue Jun 13, 2016
Make hover links on event pages do the underline. Fixes #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants