remove unnecesary clone #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you are inside a travis process, you are automatically situated under the cloned repository
hohwille
reviewed
Feb 6, 2020
Comment on lines
+32
to
-33
| # Exit devon4j folder | ||
| - cd .. | ||
| # Clone repositories | ||
| - git clone -b develop --single-branch https://${GH_REPO_SOURCE} |
There was a problem hiding this comment.
@jambulud Excellent improvement 👍 You save resources and speed up CI this way.
Could you also remove the GH_REPO_SOURCE variable if we already cleanup the travis file.
Are you doing this for all repos in devonfw? I never wrote this stuff and assume it has been copy&pasted to all major repos.
There was a problem hiding this comment.
@hohwille Removed unused variable
I just did this for devon4ng (and now devon4j) because I saw that devonfw-guide build process was not being triggered by the updates in the documentation
hohwille
added
enhancement
hohwille
pushed a commit
to hohwille/devon4j
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are inside a travis process, you are automatically situated under the cloned repository