Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spring integration test to archetype #323

Closed
hohwille opened this issue Dec 14, 2020 · 0 comments · Fixed by #376
Closed

Add spring integration test to archetype #323

hohwille opened this issue Dec 14, 2020 · 0 comments · Fixed by #376
Assignees
@suvmanda
Labels
enhancement New feature or request help wanted Extra attention is needed spring springframework and spring-boot test
Milestone
release:2021.04.001

Comments

@hohwille
Copy link
Member

With PR #312 we merged a change that broke our archetype.
This has been fixed with PR #322.
However, our integration tests running, building and testing the archetype should fail in travis when the archetype is broken and spring-boot app can not even startup.
Therefore, we need to add a general @SpringBootTest that ensures the SpringBootApp starts up without errors.
This way we will prevent such blind spots when merging PRs and wont introduce such breaking change again in the future.
@hohwille hohwille added the enhancement New feature or request label Dec 14, 2020
@hohwille hohwille added this to the release:2020.12.002 milestone Dec 14, 2020
@hohwille hohwille added help wanted Extra attention is needed spring springframework and spring-boot test labels Dec 14, 2020
@suvmanda suvmanda self-assigned this Dec 24, 2020
@hohwille hohwille modified the milestones: release:2020.12.002, release:2020.12.003 Jan 21, 2021
suvmanda added a commit to suvmanda/devon4j that referenced this issue Feb 4, 2021
@suvmanda
devonfw#323: Add spring integration test to archetype devonfw#323
5f31956
suvmanda added a commit to suvmanda/devon4j that referenced this issue Feb 4, 2021
@suvmanda
devonfw#323 :Add spring integration test
7435d91
suvmanda added a commit to suvmanda/devon4j that referenced this issue Feb 4, 2021
@suvmanda
devonfw#323 : Add spring integration test to archetype
76eb882
suvmanda added a commit to suvmanda/devon4j that referenced this issue Feb 4, 2021
@suvmanda
devonfw#323 : testing
1a52bb7
@hohwille hohwille linked a pull request Mar 25, 2021 that will close this issue
#323: Add spring integration test to archetype #323 #339
Closed
@hohwille hohwille modified the milestones: release:2020.12.003, release:2021.04.001 Apr 8, 2021
@hohwille hohwille mentioned this issue Apr 12, 2021
Closed
hohwille added a commit to suvmanda/devon4j that referenced this issue Apr 16, 2021
@hohwille
devonfw#323: fixed imports and improved asserts
35ff476
hohwille added a commit to hohwille/devon4j that referenced this issue Apr 16, 2021
@hohwille
devonfw#323: added spring integration test
af8443c
@hohwille hohwille mentioned this issue Apr 16, 2021
Merged
@hohwille hohwille linked a pull request Apr 16, 2021 that will close this issue
#323: added spring integration test #376
Merged
hohwille added a commit that referenced this issue Apr 16, 2021
@hohwille
#323: added spring integration test (#376)
6c5cfbb 
See also PR #339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suvmanda suvmanda

Labels
enhancement New feature or request help wanted Extra attention is needed spring springframework and spring-boot test
Projects
None yet
Milestone
release:2021.04.001
2 participants
@hohwille @suvmanda