Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in nsysnet and add more nn::ac functions. #401

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

dkosmari
Copy link
Contributor

@dkosmari dkosmari commented Sep 30, 2024

In nsysnet/netconfig.h:

  • Changed type of .ssid in NetConfWifiConfigData to be a char array because it's a string.
  • Fix typo in NetConfInterface: .if_sate -> .if_state.

In nn/result.h:

  • Added a default constructor for nn::Result: we need to variables of this type to pass as an output argument to some functions.

In nn/ac/ac_cpp.h:

  • Fixed wrong signature for nn::ac::GetCloseStatus(), and added the corresponding nn::ac::Status enum.
  • Added a few more functions.
  • Added the nn::ac::Config type alias to NetConfCfg.

Daniel K. O. (dkosmari) added 5 commits September 29, 2024 10:42
- fixed typo, `if_sate` -> `if_state`.

--HG--
branch : nn-ac-extras
--HG--
branch : nn-ac-extras
--HG--
branch : nn-ac-extras
--HG--
branch : nn-ac-extras
- Fixed signature of `nn::ac::GetCloseStatus()`.
- Added more functions to `nn::ac`.

--HG--
branch : nn-ac-extras
include/nsysnet/netconfig.h Show resolved Hide resolved
include/nn/ac/ac_cpp.h Outdated Show resolved Hide resolved
…tifier.

- Allow both the typo and the correct names to be used in `NetConfInterface`.

--HG--
branch : nn-ac-extras
@GaryOderNichts
Copy link
Contributor

Also please keep the 3 space indentation wut uses.

@dkosmari
Copy link
Contributor Author

dkosmari commented Oct 1, 2024

Also please keep the 3 space indentation wut uses.

I didn't realize the 3 spaces were intentional. I'll add a .dir-locals.el here to avoid mis-indenting in the future.

- Reverted typo fix to only have the correct spelling of "state".

--HG--
branch : nn-ac-extras
@GaryOderNichts GaryOderNichts merged commit 8b65fd6 into devkitPro:master Oct 1, 2024
1 check passed
@GaryOderNichts
Copy link
Contributor

Thanks!

@dkosmari dkosmari deleted the nn-ac-extra-functions branch October 1, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants