Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsysccr/cdc: Implement CCRCDCSysSetDrhState #356

Merged
merged 7 commits into from
Apr 9, 2024
Merged

nsysccr/cdc: Implement CCRCDCSysSetDrhState #356

merged 7 commits into from
Apr 9, 2024

Conversation

Maschell
Copy link
Contributor

@Maschell Maschell commented Apr 3, 2024

No description provided.

GaryOderNichts
GaryOderNichts reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCRCDCSysSetDrcState and a lot of the other CCRCDCSys functions are currently already in the cdc.h header. It probably makes sense to move this there too.

include/nn/ccr/cdc_sys.h Outdated Show resolved Hide resolved
include/nn/ccr/cdc_sys.h Outdated Show resolved Hide resolved
@Maschell Maschell force-pushed the nsysccr branch 2 times, most recently from a2a15c7 to 37b94cb Compare April 4, 2024 13:10
GaryOderNichts
GaryOderNichts reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

include/nsysccr/cdc.h Outdated Show resolved Hide resolved
include/nsysccr/cdc.h Outdated Show resolved Hide resolved
include/nsysccr/cdc.h Outdated Show resolved Hide resolved
Maschell and others added 3 commits April 8, 2024 19:05
@Maschell @GaryOderNichts
Update include/nsysccr/cdc.h
95a0e7a 
Co-authored-by: GaryOderNichts <12049776+GaryOderNichts@users.noreply.github.com>
@Maschell @GaryOderNichts
Update include/nsysccr/cdc.h
5beb4bb 
Co-authored-by: GaryOderNichts <12049776+GaryOderNichts@users.noreply.github.com>
@Maschell @GaryOderNichts
Update include/nsysccr/cdc.h
3cccbed 
Co-authored-by: GaryOderNichts <12049776+GaryOderNichts@users.noreply.github.com>
@Maschell Maschell marked this pull request as ready for review April 8, 2024 17:06
@GaryOderNichts GaryOderNichts changed the title nn_ccr: Implement CCRCDCSysSetDrhState nsysccr/cdc: Implement CCRCDCSysSetDrhState Apr 9, 2024
@GaryOderNichts GaryOderNichts merged commit 669a63b into devkitPro:master Apr 9, 2024
1 check passed
@Maschell Maschell deleted the nsysccr branch April 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryOderNichts GaryOderNichts GaryOderNichts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maschell @GaryOderNichts