Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors #252

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

Maschell
Copy link
Contributor

@Maschell Maschell commented Jul 29, 2022

The FSClient has the weird behaviour that it softlocks the console once a "fatal" error happend on the fs side. A "fatal" error can be as simple as seeking beyond the actual filesize, well.

The FSA Api returns proper error codes which can be handled instead of soft locking the console. In comparision to FS-API it doesn't support the "Command Blocks" => handling priority or canceling fs operations is not possible, but these feature where not use in the devoptab anyway.

Things left to do:

Things that can be (easier) implemented after using FSA instead of FS:

  • Proper implement lseek

@fincs fincs marked this pull request as draft July 29, 2022 15:52
@Maschell Maschell force-pushed the fsa_devoptab branch 2 times, most recently from b8846d7 to 71742c6 Compare August 9, 2022 10:54
@Maschell Maschell force-pushed the fsa_devoptab branch 4 times, most recently from f9fdc1a to ba8963c Compare February 18, 2023 07:43
@Maschell
Copy link
Contributor Author

Rebased to 1.2.0, double checked that all fixes of the "original" devoptab are also present in this PR

@Maschell Maschell force-pushed the fsa_devoptab branch 4 times, most recently from 3e04b31 to 4816a37 Compare April 8, 2023 16:46
@Maschell Maschell marked this pull request as ready for review April 8, 2023 16:48
libraries/wutdevoptab/devoptab_fsa_dirnext.cpp Outdated Show resolved Hide resolved
libraries/wutdevoptab/devoptab_fsa_utils.cpp Outdated Show resolved Hide resolved
libraries/wutdevoptab/devoptab_fsa.h Outdated Show resolved Hide resolved
@WinterMute WinterMute requested a review from fincs April 15, 2023 23:13
Copy link
Member

@fincs fincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes required (see comments)

@Maschell Maschell force-pushed the fsa_devoptab branch 3 times, most recently from aef98c9 to e1cb37a Compare April 16, 2023 12:28
@Maschell Maschell requested review from WinterMute and fincs April 16, 2023 12:31
@Maschell Maschell force-pushed the fsa_devoptab branch 2 times, most recently from d0fce06 to 22d1371 Compare April 16, 2023 16:51
@Maschell Maschell changed the title [WIP] wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors Apr 16, 2023
@WinterMute WinterMute merged commit 4083224 into devkitPro:master Apr 16, 2023
@Maschell Maschell deleted the fsa_devoptab branch April 16, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants