-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maschell
force-pushed
the
fsa_devoptab
branch
2 times, most recently
from
August 9, 2022 10:54
b8846d7
to
71742c6
Compare
Maschell
force-pushed
the
fsa_devoptab
branch
from
October 16, 2022 16:32
95ed975
to
740ed0c
Compare
Maschell
force-pushed
the
fsa_devoptab
branch
4 times, most recently
from
February 18, 2023 07:43
f9fdc1a
to
ba8963c
Compare
Rebased to 1.2.0, double checked that all fixes of the "original" devoptab are also present in this PR |
Maschell
force-pushed
the
fsa_devoptab
branch
4 times, most recently
from
April 8, 2023 16:46
3e04b31
to
4816a37
Compare
WinterMute
requested changes
Apr 15, 2023
fincs
reviewed
Apr 16, 2023
fincs
reviewed
Apr 16, 2023
fincs
reviewed
Apr 16, 2023
fincs
reviewed
Apr 16, 2023
fincs
reviewed
Apr 16, 2023
fincs
requested changes
Apr 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor changes required (see comments)
Maschell
force-pushed
the
fsa_devoptab
branch
3 times, most recently
from
April 16, 2023 12:28
aef98c9
to
e1cb37a
Compare
fincs
approved these changes
Apr 16, 2023
Maschell
force-pushed
the
fsa_devoptab
branch
2 times, most recently
from
April 16, 2023 16:51
d0fce06
to
22d1371
Compare
Maschell
changed the title
[WIP] wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors
wutdevoptab: Use the FSA API instead of FS to avoid softlocks on errors
Apr 16, 2023
WinterMute
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FSClient has the weird behaviour that it softlocks the console once a "fatal" error happend on the fs side. A "fatal" error can be as simple as seeking beyond the actual filesize, well.
The FSA Api returns proper error codes which can be handled instead of soft locking the console. In comparision to FS-API it doesn't support the "Command Blocks" => handling priority or canceling fs operations is not possible, but these feature where not use in the devoptab anyway.
Things left to do:
OSFastMutex_Lock
or a regular OSMutex (std::mutex) should be used.__init_wut_devoptab
and__fini_wut_devoptab
functions.Things that can be (easier) implemented after using FSA instead of FS: