Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Prevent builtins on transient functions #2506

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@FabioLuporini FabioLuporini added the bug-C-minor bug in the generated code not affecting correctness label Dec 20, 2024
devito/builtins/utils.py Show resolved Hide resolved
@@ -131,3 +132,23 @@ def wrapper(*args, **kwargs):
return func(*processed, argmap=argmap, **kwargs)

return wrapper


def check_args(func):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_builtins_args

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

tests/test_builtins.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (484c832) to head (2e23216).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
devito/builtins/utils.py 53.33% 6 Missing and 1 partial ⚠️
tests/test_gpu_common.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2506      +/-   ##
==========================================
- Coverage   87.29%   87.28%   -0.02%     
==========================================
  Files         238      238              
  Lines       45645    45674      +29     
  Branches     4048     4050       +2     
==========================================
+ Hits        39848    39865      +17     
- Misses       5112     5123      +11     
- Partials      685      686       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabioLuporini FabioLuporini merged commit 91be662 into master Dec 23, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the builtin-no-transient branch December 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-C-minor bug in the generated code not affecting correctness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants