compiler: Add 'groupby' mode to MapNodes visitor #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2502 +/- ##
=======================================
Coverage 87.35% 87.36%
=======================================
Files 238 238
Lines 45574 45583 +9
Branches 4035 4037 +2
=======================================
+ Hits 39813 39822 +9
Misses 5079 5079
Partials 682 682 ☔ View full report in Codecov by Sentry. |
georgebisbas
approved these changes
Dec 19, 2024
| # Replace the outermost `Iteration` with a `Call` | ||
| callback = Callable('solver', iters[0], 'void', ()) | ||
| processed = Transformer({iters[0]: Call(callback.name)}).visit(block1) | ||
|
|
There was a problem hiding this comment.
I think it is fine!
Nipick: Maybe you could add:
+assert len(iters) == 3
assert str(processed) == 'solver();'
but sure it is not needed.
There was a problem hiding this comment.
I have assert str(processed) == 'solver();' just below
georgebisbas
changed the title
FabioLuporini
approved these changes
Dec 20, 2024
mloubout
approved these changes
Dec 20, 2024
EdCaunt
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MapNodes(..., mode='groupby')back, which was dropped in #2477 and I didn't see this. It is useful for the PETSc lowering.