Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added flask icon #66

Closed
wants to merge 1 commit into from
Closed

added flask icon #66

wants to merge 1 commit into from

Conversation

moghya
Copy link
Contributor

@moghya moghya commented Jun 25, 2017

flask original and wordmark

@moghya
added flask icon
0f201d8 
flask original and wordmark
badabam
badabam reviewed Dec 8, 2017
View reviewed changes
icons/flask/flask-original.svg
@@ -0,0 +1,149 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 16.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup comments and unused lines?

@py563 py563 mentioned this pull request May 5, 2020
Closed
debdutgoswami
debdutgoswami approved these changes Jun 5, 2020
View reviewed changes
Copy link

@debdutgoswami debdutgoswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfect!! Should be merged :)

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
amacado
amacado requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

See #170 (flask is there too)

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@amacado amacado mentioned this pull request Jan 6, 2021
Merged
@amacado
Copy link
Member

amacado commented Jan 6, 2021

Closing this pull request, since it's merged/picked up in #463. @moghya will still receive credit for it.

@amacado amacado closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badabam badabam badabam left review comments

@amacado amacado amacado requested changes

@thhollev thhollev thhollev approved these changes

@debdutgoswami debdutgoswami debdutgoswami approved these changes

Assignees

@moghya moghya

Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@moghya @Thomas-Boi @amacado @badabam @thhollev @debdutgoswami