Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: perl (original, plain) #569

Merged
merged 11 commits into from
Apr 24, 2021
Merged

Conversation

mattkoskela
Copy link
Contributor

@mattkoskela mattkoskela commented Apr 22, 2021

Closes #185

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Apr 22, 2021
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 22, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues mentioned here. If it asks you to change the PR title, you must change the commit title instead. To do so, follow the steps here. In order to change the commit title, use r instead of s.

@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 22, 2021
@Thomas-Boi
Copy link
Member

Thomas-Boi commented Apr 22, 2021

@Panquesito7 It seems like the issue is the "can't make connection to OS" again. Just keep re-running the script until it works.

I tried twice already. I just re-run one more time. If it still doesn't work, wait for a few hours.

See this section for more details.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 22, 2021
devicon.json Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 23, 2021
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 23, 2021
@github-actions

This comment has been minimized.

devicon.json Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 23, 2021
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file names in the folder are in the wrong format. Please append "perl-" to the front of each file.

See this

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Apr 23, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@mattkoskela
Copy link
Contributor Author

Cleaned up the svg files and ran the svg viewer optimization!

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, everything looks good @mattkoskela! Thanks for the icon, Perl is one that a couple people has asked us about.

@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review April 24, 2021 18:19

The JSON has been updated according to our standards. Thanks for helping out :thumbsup

@Thomas-Boi Thomas-Boi merged commit 5cf9dc8 into devicons:develop Apr 24, 2021
@Panquesito7 Panquesito7 linked an issue Apr 26, 2021 that may be closed by this pull request
@mattkoskela
Copy link
Contributor Author

Do you guys have a rough idea when the next release will go out?

@Thomas-Boi
Copy link
Member

I think it will be at least for the next 2-3 weeks. It depends on how many PRs we get.

We will also be going over some of the stale PRs in the next couple days. Once we get those in (about 16 icons), I think that'll be enough for another release.

GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: perl (original, plain)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Perl
3 participants