Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon: dotnetcore (original) #533

Merged
merged 12 commits into from
Mar 19, 2021
Merged

New icon: dotnetcore (original) #533

merged 12 commits into from
Mar 19, 2021

Conversation

EnisMulic
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Mar 17, 2021
@github-actions

This comment has been minimized.

Sign in to view
Panquesito7
Panquesito7 requested changes Mar 17, 2021
View reviewed changes
icons/dotnet-core/dotnet-core-original.svg Outdated
Comment on lines 9 to 10


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

devicon.json Outdated
],
"versions": {
"svg": [
"original"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a font version of the icon (see, for example, the Jupyter icon).

@EnisMulic EnisMulic force-pushed the new_icon_dotnetcore branch from 2e3a54d to 193050b Compare March 18, 2021 07:51
@github-actions

This comment has been minimized.

Sign in to view
Panquesito7
Panquesito7 requested changes Mar 18, 2021
View reviewed changes
devicon.json Outdated
@@ -904,6 +904,23 @@
"color": "#1384c8",
"aliases": []
},
{
"name": "dot-net-core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use hyphens here. Please change back as how it was.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amacado @Thomas-Boi should it be dot-net-core or dotnetcore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily for us, we have run into this issue before. See this discussion.

I think our plan is future icons can use the dash '-' since there are no issue in terms of our current build/peek script. As long as the name in the devicon.json matches the folder name and the individual svg name, I think it should be fine.

I'll update the CONTRIBUTING.md so this is reflected properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the mentioned discussion I would suggest so stick to dotnetcore (non dashed)

icons/dot-net-core/dot-net-core-original.svg Outdated Show resolved Hide resolved
icons/dot-net-core/dot-net-core-plain.svg Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
amacado
amacado requested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to rename dot-net-core to dotnetcore #459

@EnisMulic EnisMulic force-pushed the new_icon_dotnetcore branch from adf138d to 5f977f8 Compare March 19, 2021 09:43
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Panquesito7
Panquesito7 approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Mar 19, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Thomas-Boi commented Mar 19, 2021 •
edited
Loading

Nice, everything looks great! This is ready to be merged. Thanks @EnisMulic for the icon and @Panquesito7 for checking it.

Just need a final confirmation from amacado and you guys are good 😄

@amacado amacado merged commit 3548604 into devicons:develop Mar 19, 2021
@EnisMulic EnisMulic deleted the new_icon_dotnetcore branch April 9, 2021 22:16
@amacado amacado mentioned this pull request Apr 10, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@EnisMulic @kirinnee @Panquesito7
New icon: dotnetcore (original) (devicons#533)
ae32056 
* Added amber framework

* Added dotnet core

* Add new icon: dot-net-core (original)

* Remove amber

* Add plain version and rename icon to dot-net-core

* Rename dot-net-core to dotnetcore

* Add blank line to svgs

Co-authored-by: kirinnee <kirinnee97@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EnisMulic @Thomas-Boi @amacado @Panquesito7 @kirinnee