-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: Bash (original, plain) #415
Conversation
Hi @EnisMulic , Unfortunately, we are running into some issues checking your SVGs. It seems that your forked repo is from an older version of our master branch. In order for us to check your icons, please pull our latest commit from our develop to your fork. You might find this link useful to update your repo. Cheers, |
…ature/icon/bash
Hello @EnisMulic , Sorry for the long wait. It seems that we ran into a very peculiar error that we never see before. As you might know, our repo use icomoon to create our icons. This is a browser and not an API, which means that we have to be precise in choosing which element to click etc... Normally, when we upload icons, we would remove its colors entirely using Icomoon. This is available here: When we upload your icon, we see this instead: This has never happened before so our script didn't know how to handle it. In fact, I would not be surprised if the Icomoon team just upload a new version of their app which might have cause this to happen. Any how, I had to clone your repo and test it locally to fix this issue. I have also seen your icon and it looks great to me. Thus, if you want, we can accept your PR right now. @amacado what do you think? I will open another PR that contain the fix for this issue. |
@EnisMulic congratulation, you are our first PR for 2021. Happy New Year and thanks for your work 🎉 |
new icon: Bash (original, plain)
I took the bash SVG from #170 and cleaned it up in so it doesn't use inline styles, not sure if I did this correctly.