-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gh-page in master branch / enhance auto-versioning #401
Conversation
… svg's) to /docs/dist folder allowing them to be used in GitHub page (see #394)
I suggest to look at the commits independently, so you are able to handle the "500+ files" (reason for this is mentioned in the description) |
Hey @amacado, I just want to clarify something. What is the current publishing source for our website? The site seems functional at the moment, is there anything that I'm missing? Also, it is true that choosing the Currently, this is how we get the icons and
This should break since we don't have any
I changed the Base: https://raw.githubusercontent.com/devicons/devicon/master (doesn't work by itself) The link should work since it's a normal HTTP call so it's not limited by the publishing source. It would also point to the most recent commit of master so we never have to update it. This would also eliminate the need to copy the svgs into What do you think of this approach? As for your solution for #395, I like it. It should work for a while since I don't think we need to change our release plan anytime soon. |
Currently our site is served by the branch
I came up with this solution as well, tried it and it works as expected. At first I though this would be a great idea, since it does not duplicate a bunch of files, always up to date,... But on the other hand .. seriously? I forget about the reason why I changed it (I know I had some point but i can't remember it anymore). Maybe it was just late at night and my brain got afk for a moment. I will recheck it and see the result. |
@Thomas-Boi I updated all links for fetching the resources via raw.githubusercontent and it seems to work for now. So this is ready for review and merge. Anyway: While doing this I was thinking of refactoring the page itself since it's still using the old AngularJS version which is already outdated. I'm more into VueJS these days so I might propose a updated version of the page in the upcoming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amacado That sounds good to me. I'm learning Vue right now and it is more flexible than Angular for me so I'm happy with that.
I'll approve your change and accept your PR.
…o-update-version fix gh-page in master branch / enhance auto-versioning
While implementing this new feature I noticed that the migration from gh-pages branch to master-branch does not work yet. When we want to use the /docs/ directory as entry for the GitHub page we will not have access to files stored below /docs. Therefore it's required to copy our resulting build files (as well as the svg icons) to the /docs/dist directory. This extra step allows us to reference them in the Github Page. I fixed this in
f97406d
(Implementing method for copying the resulting build files (and source svg's) to /docs/dist folder allowing them to be used in GitHub page (see #394))About the new feature:
As described in #395 we can use the github api to determine the latest release tag. This we the header (and CDN links) will auto-update itself once a new release is beeing made. This behaviour is nice, but can also cause some potential problems when we decide to change our release strategy. For now it's a simple solution and it should work as a first version. I also implemented a fallback to 'master' branch when the determination failes for any reason.