Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template format #125

Merged
merged 46 commits into from
Feb 11, 2019
Merged

New template format #125

merged 46 commits into from
Feb 11, 2019

Conversation

deviantfero
Copy link
Owner

@deviantfero deviantfero commented Jan 21, 2019

I will be changing up a few things around, there are some breaking changes, so I think this is indeed worthy of a major version release, here's a checklist of things that I'm working on:

  • use pywal's template format (python's format strings)
  • leverage pywal's Color class and conversions
  • integrate a upgrade option in wpgtk to help users with custom templates migration
  • update user defined keywords so they work with the new format
  • port all templates to new format to install under wpg-install.sh
  • remove as much duplicated code as I can
  • add option to auto-adjust on theme generation
  • order command line arguments in a more logical manner
  • remove old options that are no longer relevant (openbox, tint2) they will reload as long as they're actively running
  • add dark variant for flattrcolor
  • update documentation
  • do a small video on new template format
  • allow the reset of a theme using GUI and CLI

Now for the fun part (breaking changes)

Basically, the breaking changes come from the fact that the template format will change, I provide an example below:

#<COLOR8> becomes {color8}
#<COLORACT> becomes {active}
#<COLORIN> becomes {inactive}

if you have normal braces {{
   you will need to escape them like this
}}

but this means you can do things like: 
{color8}                -> #ffffff
{color8.octal}          -> #77777777
{active.rgb}            -> 255, 255, 255
{userdefinedcolor.rgb}  -> 0, 0, 0
#BA{color8.strip}       -> #BAffffff

This was referenced Jan 30, 2019
@deviantfero deviantfero merged commit 5a7dc23 into master Feb 11, 2019
@deviantfero deviantfero mentioned this pull request Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant