Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG Toolkit to JDK 17 LTS #362

Closed
nmandrescu opened this issue May 11, 2021 · 3 comments · Fixed by #428
Closed

Update DG Toolkit to JDK 17 LTS #362

nmandrescu opened this issue May 11, 2021 · 3 comments · Fixed by #428
Assignees
Milestone

Comments

@nmandrescu
Copy link
Contributor

It is planned for September 2021.

@developster
Copy link
Contributor

Removed cglib from classpath.

There was an error in revisions panel because AbstractPropertyModel was trying to make Enum.name writable. Replaced with a read only LambdaModel.

Could not test jersey since we are not using it in the toolkit directly.

Tested dummy endpoint and it works as expected, Jackson didn't crash the app.

@nmandrescu
Copy link
Contributor Author

nmandrescu commented Feb 7, 2022

  1. The main change is Wicket upgrade from 9.3 to the latest: since 9.5 release (Sept 12th 2021) cglib dependency was removed for JDK17 compatibility WICKET-6913.

  2. For reference, this was previously reported by Jackson at startup. Retested using Cashew-IN with latest libs and JDK17 and it is no longer reported:

WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field java.lang.reflect.Proxy.h
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field java.lang.ref.Reference.referent
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field java.lang.ref.Reference.queue
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field java.lang.ref.Reference.next
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field javax.naming.InitialContext.myProps
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field javax.naming.InitialContext.defaultInitCtx
WARNING: Illegal reflective access by com.fasterxml.jackson.databind.util.ClassUtil (file:~/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.3/jackson-databind-2.12.3.jar) to field javax.naming.InitialContext.gotDefault

Heads up: upgrading a DG Toolkit based app from JDK8/11 also requires other migration (many done preliminary with JDK16 in #365 when JDK17 wasn't yet released).

developster added a commit that referenced this issue Feb 8, 2022
@developster
Copy link
Contributor

Tested dg-toolkit for warnings from Jackson and logs are clean.

@developster developster linked a pull request Feb 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants