Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up devfile library on dependent registry test modules #396

Merged
merged 3 commits into from
May 14, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented May 14, 2024

What does this PR do?:

This PR simply bumps up the devfile/library version inside the odov3 and validate_devfile_schemas tests of the devfile/registry to the v2.2.2 version.

It also removes a temporary fix made in the past for 2.2.1 and 2.2.2 schema versions, which is no longer needed as the odo3 check has been fixed.

Which issue(s) this PR fixes:

Fixes devfile/api#1479

It also closes the following EPICs:

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk
Copy link
Contributor Author

thepetk commented May 14, 2024

FYI I've not updated anything on the konflux test as we are under discussions about the future of this check

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 14, 2024
Copy link

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 2cb41b6 into devfile:main May 14, 2024
10 checks passed
@thepetk thepetk mentioned this pull request May 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch dependent test modules under devfile/registry
2 participants